[TIMOB-24698] Fixed 3.5 year old bug that didn't surface until we sta… #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted using emulator ids instead of the name. Fixed some typos in node-titanium-sdk@0.2.5.
mukherjee2
approved these changes
May 16, 2017
There was a problem hiding this comment.
Passed FR with this environment:
Node Version: 6.10.1
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.1
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.0.v20170516141810
Xcode 8.3.2
I typed "appc run", and selected android. A default emulator was chosen and the app ran as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TIMOB-24698] Fixed 3.5 year old bug that didn't surface until we started using emulator ids instead of the name. Fixed some typos in node-titanium-sdk@0.2.5.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24698