Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24703] Generate R classes for modules #9068

Merged
merged 2 commits into from May 19, 2017

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-24703

Optional Description:
Fixes a bug in the new R.java class generation where the R class for a module was not generated.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS 👍

@ewanharris ewanharris self-requested a review May 19, 2017 14:37
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR: Pass
App launches with no problems using test steps in the ticket

OPO 3 Android 7.1.1
OSX 10.11.6
Appc NPM: 4.2.9
App CLI: 6.2.2-master.15

@ewanharris ewanharris merged commit 8aaf83c into tidev:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants