Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24703](6_1_X) Generate R classes for modules #9069

Merged
merged 3 commits into from May 19, 2017
Merged

[TIMOB-24703](6_1_X) Generate R classes for modules #9069

merged 3 commits into from May 19, 2017

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-24703

Optional Description:
6_1_X backport of #9068

@janvennemann janvennemann changed the title [TIMOB-24703] Generate R classes for modules [TIMOB-24703](6_1_X) Generate R classes for modules May 18, 2017
garymathews
garymathews approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS 👍

@garymathews garymathews added this to the 6.1.0 milestone May 18, 2017
@ewanharris ewanharris self-requested a review May 19, 2017 14:36
ewanharris
ewanharris approved these changes May 19, 2017
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR: Pass
App launches with no problems using test steps in the ticket

OPO 3 Android 7.1.1
OSX 10.11.6
Appc NPM: 4.2.9
App CLI: 6.2.2-master.15

@ewanharris ewanharris merged commit 0d83327 into tidev:6_1_X May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janvennemann @garymathews @ewanharris @mukherjee2