[TIMOB-24718]:iOS: Resolve iOS 8 deprecations for UIAlertView and UIActionSheet #9079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
requested changes
May 24, 2017
| [self fireClickEventWithAction:action]; | ||
| }]; | ||
| [alertController addAction:theAction]; | ||
| RELEASE_TO_NIL(alertController); |
There was a problem hiding this comment.
Something went wrong with the indentation starting here, making the remaining part of the PR unreadable.
There was a problem hiding this comment.
Sorry, it doesn't. The indentation just changed because of the removed if-statement. Continuing review ...
hansemannn
reviewed
May 24, 2017
| } | ||
|
|
||
| [self retain]; | ||
| [[TiApp app] showModalController:alertController animated:YES]; | ||
| } |
There was a problem hiding this comment.
Indentation looks weird here.
hansemannn
reviewed
May 24, 2017
| } | ||
|
|
||
| -(void)hide:(id)args | ||
| { | ||
| if (!showDialog) { | ||
| return; | ||
| } | ||
| if (actionSheet == nil && alertController == nil){ | ||
| if (alertController == nil){ |
hansemannn
requested changes
May 24, 2017
There was a problem hiding this comment.
Only one weird indentation issue in here and minor formatting. Please address those, then we should be good to go.
hansemannn
approved these changes
May 26, 2017
htbryant94
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-24718