Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24712] Android: Fixed TabGroup to not override ActionBar's "colorPrimary" XML theme. #9081

Merged
merged 4 commits into from May 25, 2017
Merged

[TIMOB-24712] Android: Fixed TabGroup to not override ActionBar's "colorPrimary" XML theme. #9081

merged 4 commits into from May 25, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway
[TIMOB-24712] Android: Fixed TabGroup to not override ActionBar's "co…
76ced97 
…lorPrimary" XML theme.
@jquick-axway
Android: Added null checks to TabGroup addTab() and setTabs() methods.
ba68b4c 
- Deleted the tabs.remove() in the tabs for-each loop. Would have broken the iterator and cause an exception.
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented May 24, 2017 •
edited

FR Passed.

colorPrimary of a custom theme is respected & the tab backgroundColor does not override the actionbar color from the custom theme.

Studio Ver: 4.9.0.201705180402
SDK Ver: 6.2.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.2
Appc NPM: 4.2.9
Appc CLI: 6.2.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 6 --- Android 6.0.1, Samsung Galaxy S4 --- Android 4.4.4

@lokeshchdhry lokeshchdhry merged commit 5813bad into tidev:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jquick-axway @lokeshchdhry