Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24732] Fix issue where build process would continue before zip… #9083

Merged
merged 2 commits into from Jun 21, 2017
Merged

[TIMOB-24732] Fix issue where build process would continue before zip… #9083

merged 2 commits into from Jun 21, 2017

Conversation

ewanharris
Copy link
Collaborator

… creation had finished

JIRA: https://jira.appcelerator.org/browse/TIMOB-24732

Verification:

  1. Get the titanium-google-maps module
  2. Build the module using ti build -p ios -l trace
    • Build process should not error out, and the example app should launch on device

@ewanharris ewanharris added the bug label May 24, 2017
@sgtcoolguy sgtcoolguy added the ios label Jun 8, 2017
@sgtcoolguy
Copy link
Contributor

LGTM. cc @cb1kenobi look ok?

cb1kenobi
cb1kenobi approved these changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't believe we didn't catch this sooner.

@hansemannn hansemannn added this to the 6.2.0 milestone Jun 20, 2017
@htbryant94 htbryant94 self-requested a review June 21, 2017 12:35
htbryant94
htbryant94 approved these changes Jun 21, 2017
View reviewed changes
Copy link

@htbryant94 htbryant94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Modules are now built correctly, and a working zip file was created. Running the example app as a new project with the newly built module to simulators and devices was also successful.

@htbryant94 htbryant94 merged commit 66d6a2f into tidev:master Jun 21, 2017
@ewanharris ewanharris deleted the TIMOB-24732 branch August 31, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@htbryant94 htbryant94 htbryant94 approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ewanharris @sgtcoolguy @cb1kenobi @htbryant94 @hansemannn