New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-15910] Android: Implement Ti.UI.Android.DrawerLayout #9091
Conversation
/** | ||
* @module.api | ||
*/ | ||
public static final String EVENT_DRAWER_SLIDE = "drawerslide"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name it open
, close
and slide
instead? Feels more unified with other related API's. Thx!
3d3db53
to
a8f0862
Compare
@garymathews, I have an interesting idea. I suspect that many Titanium developers may want to implement a tab group like feature via your new navigation drawer feature since that type of interface is commonly implemented on Android. Theoretically, we should be able to do this now by using a Edit: |
import android.support.v7.app.ActionBarDrawerToggle; | ||
import android.support.v7.widget.Toolbar; | ||
import android.util.Log; | ||
import android.view.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove wildcard import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the import everything else looks good.
FR Passed. The drawer layout works as expected. The left, middle & the right views are shown with the appropriate way of unhiding them. Also, different views like imageView, Label, TextView, tableview, listview etc can be successfully added to the left, middle & right drawer views. Studio Ver: 4.9.1.201707200100 |
5c006b4
to
8804182
Compare
Titanium.UI.Android.DrawerLayout
TEST CASE
JIRA Ticket