[TIMOB-24752] Android: Allow maxIdNumber to be set #9099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Please be sure to add me as a reviewer when touching anything related to CLI, tooling, or builds. Thanks. |
ssjsamir
approved these changes
Jun 28, 2017
There was a problem hiding this comment.
FR Passed : Was able to see multiple dex files when maxIdNumber was set to a low number.
Test steps:
- Create a titanium application
- Add the following to the tiapp.xml
<property name="android.dx.maxIdxNumber">1000</property> - Build the application
- Go to the build folder from Appc studio and go to the following location
build/android/bin/dexfiles - Was able to see multiple dex files
- I then changed the
maxIdNumberto 57344
<property name="android.dx.maxIdxNumber"> 57344 </property> - I could only see 1 dex file
Environment
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705251638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dx--set-max-idx-numberto be definedTEST CASE
tiapp.xml
JIRA Ticket