Fire the 'error' event if the webView receives an error.

[kosso]

This has been missing for some time.

There are many times when we need to fire the error event back to an app. (Specifically useful when dealing with OAuth authorization, since user can define a bogus callback in Twitter (for example) then parse the access tokens from the failed URL returned. This is a 'safer' approach to trying to trying to parse a 'PIN' from a web DOM, since the provider could break those implementation by simply changing the design of their pages (as has happened before).

This has been tested and does fire the error event back to an app, but does not avoid momentarily seeing the Android broswer 'not found' error page.

[negupta]

Kosso - Did you sign a CLA? If yes, please provide me the sign date and email address that you signed it with.

[marshall]

@kosso Thanks for the patch :) IIRC you've signed the CLA already yes?

Do you happen to have the test app you used to test your fix? We will need a simplified test case to verify your code

[kosso]

I'm pretty sure I did ages ago ;)

If not, feel free to send me another one.

I'll knock up some test code.

[marshall]

@kosso sweet thanks! :)

[negupta]

@kosso - I cannot find the signed CLA in the database. Please give me your full name and I will search again.

[marshall]

@kosso
FYI, This is the link for our CLA (which may've changed since you originally signed)
https://wiki.appcelerator.org/display/guides/How+to+Contribute+Code#HowtoContributeCode-SigningtheContributorsLicenseAgreement%28CLA%29

[kosso]

Got it. Will do.

BTW, the text on the echosign doc still says it'll be sent to Tony.

[negupta]

Signed CLA is in place now.

[marshall]

@kosso thanks! Now we just need a JIRA issue and test case and we can get rolling on reviewing this :)

[kosso]

/bangs head on desk/ - this is easy, eh? ;p ok ok

[tonylukasavage]

@kosso, did you get squared away here with a ticket and test case? Just want to make sure you're getting taken care of here.

[negupta]

Closing PR due to lack of response from the submitter. Feel free to reopen it if you wish to follow up.

[kosso]

Could someone tell me WHERE to exactly send an example of this very important omission of basic functionality for a webView?

The original source code even says "//TODO report this to the user" - so I 'did' it ;)

I see from the current source that an Android webView still does not report anything to a user on an error.

Thanks.

[kosso]

Github says "You don't have permission to reopen this issue"

[kosso]

Please see this very simple example on JIRA:

https://jira.appcelerator.org/browse/TC-936

[negupta]

@kosso - Thanks for pointing us to the JIRA ticket. I have reopened this PR and we will review it shortly.

[hieupham007]

I don't think we need to include "description", "errorCode", and "message" properties to match parity. Also, "type" property will be added automatically, so you shouldn't do that manually ("type" is supposed to be the name of the event).

[billdawson]

CR/FR accepted