Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24756] Android: Fix ImageView animation task #9103

Merged
merged 2 commits into from Jun 5, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jun 1, 2017

  • Fix termination of animator thread in ImageView
  • This issue has been exposed due to fixing a previous memory leak
TEST CASE
var win = Ti.UI.createWindow({backgroundColor: 'gray'}),
    iv = Ti.UI.createImageView({
        duration: 1000,
        images: ['red.png', 'green.png', 'blue.png']
    });

iv.start();

setTimeout(function() {
	win.close();
}, 3000);

win.add(iv);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 6.2.0 milestone Jun 1, 2017
@garymathews garymathews requested a review from ypbnv June 1, 2017 14:43
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR:Pass

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Was able to see the animation of the box switch from red to green to blue. I then saw the application close without any issues.

Test Steps

  • Downloaded the SDK Build form this PR
  • Created a new Titanium project
  • Copied the the test case from description
  • Downloaded - red.png, green.png, blue.png
  • Added the three images to the resources folder of the application
  • Ran the application
  • Saw the animation take place and the program closed without any issues

Test Environement
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850

@ssjsamir ssjsamir merged commit 689db29 into tidev:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants