Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_1_X][TIMOB-24756] Android: Fix ImageView animation task #9109

Merged
merged 1 commit into from Jun 5, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews changed the title [6_1_X][TIMOB-24756] Android: Fix termination of animator thread in ImageView [6_1_X][TIMOB-24756] Android: Fix ImageView animation task Jun 5, 2017
@ssjsamir ssjsamir self-requested a review June 5, 2017 22:45
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master: #9103

FR Passed: Was able to see the animation of the box switch from red to green to blue. I then saw the application close without any issues.

Test Steps

  • Downloaded the SDK Build form this PR
  • Created a new Titanium project
  • Copied the the test case from description
  • Downloaded - red.png, green.png, blue.png
  • Added the three images to the resources folder of the application
  • Ran the application
  • Saw the animation take place and the program closed without any issues

Test Environement
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
npm: 4.2.8
Xcode: 8.2

@ssjsamir ssjsamir merged commit 05b3cfc into tidev:6_1_X Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants