[TIMOB-24753]: iOS View sizes are incorrect in 6.1.0.GA (regression) #9120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
approved these changes
Jun 7, 2017
There was a problem hiding this comment.
As the ticket that implemented the bounding-rect usage works with this solution. But please note that the maxSize property was there for another reason, see the 480px check in it's declaration. I am still validating that case, but QE can already proceed with their tests. Required label-tests are:
- horizontal / vertical layout
- auto-width (FILL and SIZE) / percentages / static values
- label container that size different than the children / label
- left / right usages
We may want to create an own layout-focussed QE-app if we don't have so far. This kind of changes are always too sensitive to test with only 1-2 test-cases.
htbryant94
approved these changes
Jun 9, 2017
There was a problem hiding this comment.
Approved! View sizes are now calculated correctly when using percentages. Additionally, performed tests related to the following parameters:
- horizontal / vertical layout
- auto-width (FILL and SIZE) / percentages / static values
- label container that size different than the children / label
- left / right usages
- Portrait / Landscape Orientations
Tested on Device and Simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-24753