Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24773] Updated to ioslib@1.4.2 which fixes support for Xcode 9. #9129

Merged
merged 2 commits into from Jun 7, 2017
Merged

[TIMOB-24773] Updated to ioslib@1.4.2 which fixes support for Xcode 9. #9129

merged 2 commits into from Jun 7, 2017

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi
[TIMOB-24773] Updated to ioslib@1.4.2 which fixes support for Xcode 9.
4d254d4
@cb1kenobi
Adding node-ios-device binaries that were missing. There is no functi…
8a3b557 
…onality change. Just adding what should have been there in the first place, but wasn't thanks to a bug in node-ios-device's download script, which has been fixed.
@ewieberappc ewieberappc self-requested a review June 7, 2017 21:54
ewieberappc
ewieberappc approved these changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed.
Able to detect and build to iOS 11 simulators using Xcode 9 beta, without issue. Tested by creating several projects and building them for different simulators with different CLI options. iOS 11 sims are also detected by 'ti info' and in Studio.

@cb1kenobi cb1kenobi requested review from hansemannn and removed request for hansemannn June 7, 2017 22:01
@ewieberappc ewieberappc merged commit 2ddb13b into tidev:master Jun 7, 2017
@cb1kenobi cb1kenobi deleted the timob-24773 branch June 7, 2017 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewieberappc ewieberappc ewieberappc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cb1kenobi @ewieberappc