Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24794] Updated to ioslib@1.4.3 which updates to node-ios-devic… #9130

Merged
merged 6 commits into from Jun 16, 2017
Merged

[TIMOB-24794] Updated to ioslib@1.4.3 which updates to node-ios-devic… #9130

merged 6 commits into from Jun 16, 2017

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi cb1kenobi commented Jun 7, 2017 •
edited

[TIMOB-24794] Updated to ioslib@1.4.3 which updates to node-ios-device@1.3.3 and adds support for Node.js 8.

JIRA: https://jira.appcelerator.org/browse/TIMOB-24794

@cb1kenobi cb1kenobi self-assigned this Jun 7, 2017
@hansemannn
Copy link
Collaborator

node-ios-device supporting Node 8 does not mean that Titanium supports Node 8 right? How is the status of supporting node 6/7 right now? I think I lost track about it.

@cb1kenobi
Copy link
Contributor Author

@hansemannn I have been using Node 8 for a while now with Titanium and it seems to work just fine. Even node-ios-device worked, but that's because it detected the binary was missing and rebuilt it for Node 8 on-the-fly. We got lucky. Sometimes a new Node version will break native addons.

@sgtcoolguy
Copy link
Contributor

@hansemannn @ewieberappc What can we do to move this PR on? I'd like to get this in and merged so that I can update #9048 with it and then merge that in (moving from checked-in node_modules to using npm5's package-lock.json).

hansemannn
hansemannn approved these changes Jun 12, 2017
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Chris about some lines - LGTM, but would like to request a CR from @janvennemann just to be sure.

janvennemann
janvennemann approved these changes Jun 12, 2017
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cb1kenobi cb1kenobi changed the title [TIMOB-24794] Updated to ioslib@1.3.4 which updates to node-ios-devic… [TIMOB-24794] Updated to ioslib@1.4.3 which updates to node-ios-devic… Jun 16, 2017
ewieberappc
ewieberappc approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed. Able to build for sim and device using recent Xcodes (except 8.3.3 because of a known bug). No issues encountered and built apps ran without error.

@ewieberappc ewieberappc merged commit fc2dda0 into tidev:master Jun 16, 2017
@cb1kenobi cb1kenobi deleted the timob-24794 branch June 16, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@ewieberappc ewieberappc ewieberappc approved these changes

@hansemannn hansemannn hansemannn approved these changes

Assignees

@cb1kenobi cb1kenobi

Labels
bug improvement ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cb1kenobi @hansemannn @sgtcoolguy @janvennemann @ewieberappc