(6_1_X) [TIMOB-24796] iOS: Hybrid CommonJS and Native modules don't handl… #9132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e multiple js files
hansemannn
approved these changes
Jun 9, 2017
hansemannn
requested changes
Jun 9, 2017
iphone/Classes/TiModule.m
Outdated
| return [moduleAssets performSelector:@selector(resolveModuleAsset:) withObject:fromPath]; | ||
| // Look up the file by it's original name. We preserve the filename in our Node-js based module build | ||
| NSData* data = [moduleAssets performSelector:@selector(resolveModuleAsset:) withObject:fromPath]; | ||
| if (data != null) { |
hansemannn
approved these changes
Jun 12, 2017
mukherjee2
approved these changes
Jun 15, 2017
There was a problem hiding this comment.
Passed FR! With this environment:
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.1 pr/9132
Appcelerator Studio, build: 4.9.0.201705302345-39
Xcode 8.3.2
I followed the instructions in the ticket to build the module. The module was successfully built. Then I used the module in the demo app. App worked as expected, and no errors were seen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24796
Optional Description:
back port of #9131