[TIMOB-24809] Android: HTTPClient - "onload" not dispatched. #9139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear parts and pairs collections before reusing the client.
garymathews
suggested changes
Jun 12, 2017
| //Clear parts and nvPairs before sending new data | ||
| nvPairs.clear(); | ||
| parts.clear(); | ||
|
|
There was a problem hiding this comment.
It would be better to clear the values only after they have been used:
if (nvPairs.size() > 0) {
try {
form = new UrlEncodedFormEntity(nvPairs, "UTF-8");
} catch (UnsupportedEncodingException e) {
Log.e(TAG, "Unsupported encoding: ", e);
}
nvPairs.clear();
}for(String name : parts.keySet()) {
Log.d(TAG, "adding part " + name + ", part type: " + parts.get(name).getMimeType() + ", len: "
+ parts.get(name).getContentLength(), Log.DEBUG_MODE);
addFilePart(name, parts.get(name));
}
parts.clear();
|
@garymathews Updated. |
garymathews
changed the title
garymathews
changed the title
ssjsamir
approved these changes
Jun 13, 2017
There was a problem hiding this comment.
FR Passed: Error is no longer shown when a request is finished.
Test Steps:
- Downloaded the SDK Build form this PR
- Created a new Titanium project
- Copied the the test case from description
- Ran the application
- Pressed
Get Photos - Saw the Response via alert box
- Pressed the
uploadbutton - Error was not shown
- Saw the Response via alert box
Test Environment
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705251638
garymathews
reviewed
Jun 13, 2017
| @@ -730,6 +731,11 @@ public String getResponseHeader(String getHeaderName) | |||
|
|
|||
| public void open(String method, String url) | |||
| { | |||
| if (requestPending) { | |||
| Log.w(TAG,"Open canceled. Connection is already opened and a request is pending."); | |||
There was a problem hiding this comment.
Log.w(TAG, "open cancelled, a request is already pending for response.");
- space after comma
garymathews
reviewed
Jun 13, 2017
| @@ -1009,6 +1015,13 @@ private Object titaniumFileAsPutData(Object value) | |||
|
|
|||
| public void send(Object userData) throws UnsupportedEncodingException | |||
| { | |||
|
|
|||
| if (requestPending) { | |||
| //Log.w(TAG,"Request currently in transmission!"); | |||
There was a problem hiding this comment.
Remove this commented line
garymathews
reviewed
Jun 13, 2017
|
|
||
| if (requestPending) { | ||
| //Log.w(TAG,"Request currently in transmission!"); | ||
| Log.w(TAG,"Send canceled. A request with the same TiHTTPClient is pending!"); |
There was a problem hiding this comment.
Log.w(TAG, "send cancelled, a request is already pending for response.");
|
@garymathews Updated warning messages. |
ssjsamir
approved these changes
Jun 14, 2017
There was a problem hiding this comment.
FR Passed following the earlier steps. However I did change the requestbin link as the link had expired.
var window = Ti.UI.createWindow();
var buttonUpload = Ti.UI.createButton({title:"Upload", top:50});
var buttonGetPhotos = Ti.UI.createButton({title:"Get Photos", top: 110});
var xhr = Titanium.Network.createHTTPClient({timeout:5000});
var tempF = Ti.Filesystem.getFile(Ti.Filesystem.resourcesDirectory,"simpleTest.png");
Ti.API.info(tempF);
buttonUpload.addEventListener('click', function (e) {
xhr.open("POST","https://requestb.in/16ixvgy1");
var data_to_send = {
"file": tempF.read(),
};
xhr.onload = function () {(alert(this.responseText))};
xhr.send(data_to_send);
});
buttonGetPhotos.addEventListener('click', function (e) {
xhr.open("POST","https://requestb.in/16ixvgy1");
var params = {
id:46
};
xhr.onload = function (e) {alert(this.responseText)};
xhr.send(params);
});
window.add(buttonGetPhotos);
window.add(buttonUpload);
window.open();
Test Steps:
- Downloaded the SDK Build form this PR
- Created a new Titanium project
- Copied the the test case from description
- Ran the application
- Pressed
Get Photos - Saw the Response
- Pressed the
uploadbutton - Error was not shown
Test Environment
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705251638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear parts and nvPairs before reusing the client.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24809