[TIMOB-24504] Android: Implement bundled notifications

[garymathews]

• Implement bundled notifications for Android N

TEST CASE

var win = Ti.UI.createWindow({title: 'TIMOB-24504', layout: 'vertical'}),
    btn_normal = Ti.UI.createButton({title: 'CREATE NOTIFICATIONS', height: 50, width: Ti.UI.FILL}),
    btn_group = Ti.UI.createButton({title: 'CREATE GROUP NOTIFICATIONS', height: 50, width: Ti.UI.FILL}),
    id = 100;

function createNotifications(num, group) {
    for (var i = num; i > 0; i--) {
        var n = Ti.Android.createNotification({
            icon: Ti.Android.R.drawable.ic_dialog_info,
            contentTitle: 'NOTIFICATION #' + i,
            contentText : 'Lorem ipsum dolor sit amet, facer eruditi omittantur cu pri, nibh nonumy putant eam eu.'
        });
        if (group) {
            n.setGroup(group);
        }
        Ti.Android.NotificationManager.notify(id++, n);
    }
    if (group) {
        var n = Ti.Android.createNotification({
            icon: Ti.Android.R.drawable.ic_dialog_info,
            contentTitle: 'NOTIFICATIONS',
            contentText : 'You have ' + num + ' notifications.',
            group: group,
            groupSummary: true
        });
        Ti.Android.NotificationManager.notify(id++, n);
    }
}

btn_normal.addEventListener('click', function() {
    createNotifications(3);
});

btn_group.addEventListener('click', function() {
    createNotifications(3, 'group_key');
});

win.add([btn_normal, btn_group]);
win.open();

NOTE: this requires #9027

JIRA Ticket

[jquick-axway]

@garymathews, your doc changes state that this feature is only supported on Android 7 and higher, but since we're using Google's NotificationCompat, the Java setGroup() and setGroupSummary() methods are (according to Google; link below) supposed to be supported on older Android OS versions as well.
https://android-developers.googleblog.com/2016/06/notifications-in-android-n.html

You may want to double check. Although, a stackoverflow post I've seen suggests that notification bundles via this compat library doesn't work on Android 4.0.
https://stackoverflow.com/questions/31483772/android-grouped-notifications-and-summary-still-shown-separately-on-4-4-and-bel

[jquick-axway]

Also, I think the "group" property should be renamed to "groupKey".

This makes it clear to the reader that this property must be given a string key. Versus a name like "group" implies that it stores/provides a collection of items. I know what I'm suggesting doesn't match Google's equivalent Java method, but it does match how they document it.

[garymathews]

@jquick-axway Updated PR.

[jquick-axway]

Looks good. And definitely a great feature to add.

Just 1 question and 1 minor change request left.

[jquick-axway]

Our APIs use American English spelling rules. So, we should rename "Behaviour" to "Behavior", without the 'u'. (Sorry)

This would match our spelling with iOS' notification behavior property...
http://docs.appcelerator.com/platform/latest/#!/api/Titanium.App.iOS.UserNotificationAction-property-behavior

[jquick-axway]

Regarding notification.flags |= this.flags, is there a reason why you are changing it from an assignment to a bitwise-or operation? (Just curious in case there is something I'm not seeing here.)

I ask because the NotificationBuilder might set bits that can no longer be removed and the developer would have no means of clearing them. Versus the developer used to be able to set the exact flags he/she wanted before.

[jquick-axway]

Never mind. The "Notification.Builder" sets flags (such as group summary) that we don't want to clear with an assignment.

[garymathews]

@jquick-axway Updated

[lokeshchdhry]

FR Passed.

The groupkey & the groupSummary properties works as expected. Also, notifications with this property group/bundle into a single notification.

Studio Ver: 4.9.1.201707200100
SDK Ver: 6.2.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.3-21
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.13
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: Android 7.0