Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24839] Fix Ti.UI.Window object release #9145

Merged
merged 3 commits into from Jun 19, 2017

Conversation

garymathews
Copy link
Contributor

  • Do not fully release Titanium.UI.Window object onDestroy
TEST CASE
var a = Ti.UI.createWindow({backgroundColor: 'blue', title: 'Blue'}),
	b = Ti.UI.createWindow({backgroundColor: 'red', title: 'Red'});

a.addEventListener('click', function() {
	b.open();
	a.close();
});
b.addEventListener('click', function() {
	a.open();
	b.close();
});

a.open();

JIRA Ticket

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Jun 19, 2017

FR Passed.

Opening a closed window does not crash the app.

  1. Checked with the attached code.
  2. Check it on tab group windows.

Studio Ver: 4.9.0.201705302345
SDK Ver: 6.2.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.2
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 89ee876 into tidev:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants