Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6_1_X][TIMOB-24839] Fix Ti.UI.Window object release #9146

Merged
merged 2 commits into from Jun 19, 2017
Merged

[6_1_X][TIMOB-24839] Fix Ti.UI.Window object release #9146

merged 2 commits into from Jun 19, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 6.1.1 milestone Jun 16, 2017
@garymathews garymathews requested a review from ypbnv June 16, 2017 10:26
ypbnv
ypbnv approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR:Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

Opening a closed window does not crash the app.

Checked with the attached code.
Check it on tab group windows.
Studio Ver: 4.9.0.201705302345
SDK Ver: 6.1.1 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.2
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 8eb42cf into tidev:6_1_X Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
6.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @lokeshchdhry @ypbnv @ssjsamir