Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMBO-24837] Upgraded to ioslib@1.4.6 which fixes support for Xcode … #9153

Merged
merged 3 commits into from Jun 21, 2017
Merged

[TIMBO-24837] Upgraded to ioslib@1.4.6 which fixes support for Xcode … #9153

merged 3 commits into from Jun 21, 2017

Conversation

cb1kenobi
Copy link
Contributor

[TIMBO-24837] Upgraded to ioslib@1.4.5 which fixes support for Xcode 8.3.3 and iOS 10.3.1. Also fixes a typo bug.

JIRA: https://jira.appcelerator.org/browse/TIMOB-24837

See ticket for test information.

…8.3.3 and iOS 10.3.1. Also fixes some typo bugs.
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@hansemannn
Copy link
Collaborator

@cb1kenobi Can you push the latest fixes from ioslib? I cannot approve it here until then.

Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed.
The correct Xcode/simulators are selected when using Xcode 8.2, 8.3.2, 8.3.3, and 9.0b. Tested by having Xcode(s) installed and building for sim, device, adhoc, and appstore, then verifying that the correct Xcode and/or simulator version was selected for the build, as well as ensuring the app would install/launch/verify.

@ewieberappc ewieberappc merged commit ca8ac7b into tidev:master Jun 21, 2017
@cb1kenobi cb1kenobi deleted the timob-24837 branch June 21, 2017 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants