Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24842] Android: Fix Ti.UI.View.opacity property change #9154

Merged
merged 2 commits into from Jun 19, 2017

Conversation

garymathews
Copy link
Contributor

  • Fix Titanium.UI.View opacity property change
  • Remove redundant code
TEST CASE
var win = Ti.UI.createWindow({backgroundColor: 'gray'}),
    view = Ti.UI.createView({
        backgroundColor: 'blue', width: 200, height: 200
    });

view.addEventListener('click', function(e) {
	view.opacity = 0.5;
});

win.add(view);
win.open();

JIRA Ticket

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir requested review from ssjsamir and ypbnv June 19, 2017 17:14
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed: Was able to see the opacity change when clicking on the blue square.

Test Steps

  • Downloaded the SDK Build form this PR
  • Created a new Titanium project
  • Copied the the test case from description
var win = Ti.UI.createWindow({backgroundColor: 'gray'}),
    view = Ti.UI.createView({
        backgroundColor: 'blue', width: 200, height: 200
    });

view.addEventListener('click', function(e) {
	view.opacity = 0.5;
});

win.add(view);
win.open();
  • Ran the application
  • Pressed the blue square
  • Saw the opacity decrease

Test Environment
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705251638

@ssjsamir ssjsamir merged commit 37b4e67 into tidev:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants