[TIMOB-18914] Android: Mark splitActionBar as removed #9156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove from source. Mark in documentation as "removed".
This reverts commit 0ba67b4.
|
@hansemannn Reverted the code removal. Added only deprecation tag and some notes. I guess we can link the Ti.UI.Toolbar in the notes once we have it moved on both platforms in the proper module. |
|
@ypbnv , can QE do a FR for this ? Is CR pending ? |
hansemannn
requested changes
Aug 10, 2017
| @@ -784,6 +784,9 @@ properties: | |||
| type: Boolean | |||
| since: 3.6.0 | |||
| availability: creation | |||
| deprecated: | |||
| since: 6.2.0 | |||
| notes: Deprecated in AppCompat theme. The same behaviour can be achived by using Toolbar. | |||
There was a problem hiding this comment.
So it still work? When you deprecate it, it still has to work. In case it does not anymore, it has to go into a major version (7.0.0).
There was a problem hiding this comment.
Yes, it should work. On Titanium SDK less than 4.0.0. Material Theme was added in that version and it does not support this property.
garymathews
approved these changes
Aug 17, 2017
|
Passes FR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove from source. Mark in documentation as "removed".
JIRA: https://jira.appcelerator.org/browse/TIMOB-18914