New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24851] Android: Fix Ti.UI.Label.wordWrap behaviour #9160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR:Pass
Will refactor once #9161 has been merged. |
@garymathews ping: #9161 has been merged. If this is targeted for 7.0.1, then we'll need a backport/cherry-pick (and the JIRA ticket should have a fixVersion) |
@garymathews Merge conflicts and backport? We have too many open "7.1.0" PR's without backport right now. |
FR Passed.
Studio Ver: 5.1.0.201804230827 |
@garymathews , Can you please resolve the conflicts. |
@lokeshchdhry Resolved |
Tests:
Generated by 🚫 dangerJS |
Generated by 🚫 dangerJS |
Looks like these changes already snuck in somehow... |
The "wordWrap" change isn't in yet. I'll create a new PR. |
Here is the new PR: #10480 |
wordWrap
should still allow new-lines when set tofalse
TEST CASE
JIRA Ticket