Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24851] Android: Fix Ti.UI.Label.wordWrap behaviour #9160

Closed
wants to merge 7 commits into from

Conversation

garymathews
Copy link
Contributor

  • wordWrap should still allow new-lines when set to false
TEST CASE
var win = Ti.UI.createWindow(),
    lbl = Ti.UI.createLabel({
        left: 0,
        text: 'This is some very long test text that should span accross the screen.\nThis is a new line for test text.',
        ellipsize: Titanium.UI.TEXT_ELLIPSIZE_TRUNCATE_NONE,
        wordWrap: false
    });

win.add(lbl);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 6.2.0 milestone Jun 19, 2017
@garymathews garymathews requested a review from ypbnv June 19, 2017 20:03
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR:Pass

@garymathews
Copy link
Contributor Author

Will refactor once #9161 has been merged.

@hansemannn hansemannn modified the milestones: 7.0.0, 6.2.0 Aug 15, 2017
@sgtcoolguy sgtcoolguy modified the milestones: 7.0.0, 7.1.0 Nov 30, 2017
@sgtcoolguy
Copy link
Contributor

@garymathews ping: #9161 has been merged. If this is targeted for 7.0.1, then we'll need a backport/cherry-pick (and the JIRA ticket should have a fixVersion)

@hansemannn
Copy link
Collaborator

@garymathews Merge conflicts and backport? We have too many open "7.1.0" PR's without backport right now.

@hansemannn hansemannn modified the milestones: 7.1.0, 7.2.0 Feb 26, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

newline is allowed when wordwrap is set to false.

Studio Ver: 5.1.0.201804230827
SDK Ver: 7.2.0.v20180509085211
OS Ver: 10.13.4
Xcode Ver: Xcode 9.3
Appc NPM: 4.2.13
Appc CLI: 7.0.3
Daemon Ver: 1.1.1
Ti CLI Ver: 5.1.0
Alloy Ver: 1.12.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry
Copy link
Contributor

@garymathews , Can you please resolve the conflicts.

@garymathews
Copy link
Contributor Author

@lokeshchdhry Resolved

@build
Copy link
Contributor

build commented May 9, 2018

Fails
🚫

Tests have failed, see below for more information.

Messages
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.UI.ScrollableView moveX-scrollTo 20.012 Error: timeout of 20000ms exceeded
android.Titanium.UI.WebView userAgent 11.222 Error: timeout of 10000ms exceeded

Generated by 🚫 dangerJS

@build
Copy link
Contributor

build commented Oct 30, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@sgtcoolguy
Copy link
Contributor

Looks like these changes already snuck in somehow...

@sgtcoolguy sgtcoolguy closed this Nov 5, 2018
@jquick-axway
Copy link
Contributor

The "wordWrap" change isn't in yet.
What happened my PR #9161 refactored the code and moved the setSingleLine() method calls to a different place in the code.

I'll create a new PR.

@jquick-axway
Copy link
Contributor

Here is the new PR: #10480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants