Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(6_1_X)[TIMOB-24800] Lower aar transform hook priority #9168

Merged
merged 1 commit into from Jun 21, 2017
Merged

(6_1_X)[TIMOB-24800] Lower aar transform hook priority #9168

merged 1 commit into from Jun 21, 2017

Conversation

janvennemann
Copy link
Contributor

@janvennemann
[TIMOB-24800] Lower aar transform hook priority
e3e0784 
Alloy will wipe the platform directory and copy the contents from app/platform there. Due to that we need to make sure the Android Library transform hook (which reads .aar files from platform/android) will be run after Alloy because they are both started on the build.pre.compile hook.
cb1kenobi
cb1kenobi approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM.

@mukherjee2 mukherjee2 self-requested a review June 21, 2017 19:04
mukherjee2
mukherjee2 approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR:
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: local built with PR/9168
Appcelerator Studio, build: 4.9.0.201705302345
Xcode 8.3.2
Hyperloop 2.1.1

@mukherjee2 mukherjee2 removed the request for review from garymathews June 21, 2017 21:03
@mukherjee2 mukherjee2 merged commit f96f1fd into tidev:6_1_X Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@mukherjee2 mukherjee2 mukherjee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janvennemann @cb1kenobi @mukherjee2