Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24870] Android: Do not release child views from Window during onDestroy #9169

Merged
merged 3 commits into from Jun 22, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jun 21, 2017

  • Do not release the child views of Ti.UI.Window on close()
TEST CASE
var a = Ti.UI.createWindow({backgroundColor: 'blue', title: 'Blue'}),
	b = Ti.UI.createWindow({backgroundColor: 'red', title: 'Red'}),
	lbl = Ti.UI.createLabel({text: 'THIS SHOULD BE VISIBLE!'});
 
a.addEventListener('click', function() {
	b.open();
	a.close();
});
b.addEventListener('click', function() {
	a.open();
	b.close();
});
 
a.add(lbl);
a.open();

JIRA Ticket

@garymathews garymathews added this to the 6.2.0 milestone Jun 21, 2017
@garymathews garymathews changed the title [TIMOB-24870] Android: Do no release child views from Window during onDestroy [TIMOB-24870] Android: Do not release child views from Window during onDestroy Jun 21, 2017
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@mukherjee2 mukherjee2 self-requested a review June 22, 2017 00:53
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR with this environment:
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.X locally built from PR/9170
Appcelerator Studio, build: 4.9.0.201705302345
Xcode 8.3.2

I first reproduce the bug on SDK 6.1.0. Tapping on the blue window turned red. Next, tapping on the red window caused the app to crash. Then I tried the demo app with the proposed fix, and found that when tapping on the window alternates between the blue window and red window with no errors. FR passed.

@mukherjee2 mukherjee2 merged commit 610e91f into tidev:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants