Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24884] Updated node-titanium-sdk@0.3.1 which updated its deps … #9176

Merged
merged 2 commits into from Jun 26, 2017
Merged

[TIMOB-24884] Updated node-titanium-sdk@0.3.1 which updated its deps … #9176

merged 2 commits into from Jun 26, 2017

Conversation

cb1kenobi
Copy link
Contributor

[TIMOB-24884] Updated node-titanium-sdk@0.3.1 which updated its deps and fixes the minification issue.

JIRA: https://jira.appcelerator.org/browse/TIMOB-24884

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR looks fine. Did not do FR...

@mukherjee2 mukherjee2 self-requested a review June 26, 2017 21:11
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR.
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.X locally built w/ pr/9177
Appcelerator Studio, build: 4.9.0.201705302345
Xcode 8.3.2
iOS Device 10

I tried the demo apps in the ticket, TIMOB-24884. there were no errors when launched. For the "movies" app I also pushed a button, and there were no errors.

@mukherjee2 mukherjee2 merged commit b95498e into tidev:master Jun 26, 2017
@cb1kenobi cb1kenobi deleted the timob-24884 branch June 26, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants