Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18182] iOS: Add "inBackground" to local push notification #9180

Merged
merged 5 commits into from Jul 20, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 6.2.0 milestone Jun 29, 2017
@@ -1217,6 +1217,10 @@ properties:
type: Dictionary
optional: true
since: "5.4.0"

- name: inBackground
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be written inside
events :
"localnotificationaction" and "notification" section because it tells the about received data and "inBackground" is property of received local notification data. Currently it written inside " NotificationParams", which is local notification creation object.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated the PR.

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FT passed.

@hansemannn hansemannn merged commit 5856177 into tidev:master Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants