New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-14565] iOS: Fix default font-sizes (parity) #9182
Conversation
return result; | ||
} | ||
|
||
+(WebFont *)tableRowFont |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why deleted ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused since the iOS 7 release was created, just a quick clean-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR and FT passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed Font sizes now align the defaults to the native defaults.
Test steps:
- Created a Titanium SDK using this PR
- Created a new titanium project
- Copied the code from the test case in https://jira.appcelerator.org/browse/TIMOB-14565
- Ran the project
- Pressed
just a test label
- Text does no longer change
Test Environement
Iphone 6S(iOS 10.0)
Appcelerator Command-Line Interface, version 6.2.2
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705251638
JIRA: https://jira.appcelerator.org/browse/TIMOB-14565