[TIMOB-24912] Android: Running a module after it was built fails on Windows. #9184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
approved these changes
Jul 5, 2017
cb1kenobi
reviewed
Jul 5, 2017
android/cli/commands/_buildModule.js
Outdated
| } | ||
| function runTiCommand(cmd, args, logger, callback) { | ||
|
|
||
| // when calling on Windows, we need to escape ampersands in the command |
There was a problem hiding this comment.
Please fix the indention here. We use tabs, not spaces.
cb1kenobi
requested changes
Jul 5, 2017
|
@cb1kenobi Updated with proper indentation. |
cb1kenobi
requested changes
Jul 6, 2017
android/cli/commands/_buildModule.js
Outdated
| if (process.platform == 'win32' && /\.bat$/.test(cmd)) { | ||
| args.unshift('/S', '/C', cmd.replace(/\&/g, '^&')); | ||
| cmd = 'cmd.exe'; | ||
| function runTiCommand(cmd, args, logger, callback) { |
There was a problem hiding this comment.
Sorry to knit pick, but you have trailing whitespace.
There was a problem hiding this comment.
I have totally missed that.
|
@cb1kenobi Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24912
Change parameters to work both on macOS and Windows.
Description:
On Windows Node child processes need to be run in a new console. This changes the command to point to the node executable and adds the old command as a parameter. This way it should work on both operating systems.