[TIMOB-24916] iOS: Guard json-stringification for Ti.Geolocation.lastGeolocation #9186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysingh-axway
approved these changes
Jul 5, 2017
ssjsamir
approved these changes
Jul 11, 2017
There was a problem hiding this comment.
FR Passed: Application no longer crashed when Ti.Geolocation.getLastGeolocation is called before a geoLocation is set.
Test steps
- Created a Titanium SDK using this PR
- Created a new titanium project
- Copied the code from the test case in https://jira.appcelerator.org/browse/TIMOB-24916
- Ran the project
- Pressed
Get GeoBefore geoLocation started - Application no longer crashed and the following was shown in the console
[DEBUG] : Location undefined
Test Environment
Iphone 6S(iOS 10.0)
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705251638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24916