Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24926] Android: Prevent fireEvent on null proxy #9189

Merged
merged 2 commits into from Jul 10, 2017

Conversation

garymathews
Copy link
Contributor

  • Prevent fireEvent from taking place on a null proxy during release
TEST CASE
var win = Ti.UI.createWindow(),
    a = Ti.UI.createView(),
    b = Ti.UI.createView(),
    c = Ti.UI.createView(),
    row = Ti.UI.createTableViewRow(),
    table = Ti.UI.createTableView({data: [row]}),
    scrollableView = Ti.UI.createScrollableView({
      views: [a, b, c]
    }),
    i = 0;

row.add(Ti.UI.createImageView());
c.add(table);

setInterval(function() {
    scrollableView.currentPage = i++ % 3;
}, 1000);

win.add(scrollableView);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 6.2.0 milestone Jul 3, 2017
@garymathews garymathews requested a review from ypbnv July 3, 2017 14:29
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.1.GA
Appcelerator Studio, build: 4.9.0.201705302345
Xcode 8.3.2
FR Passed with above environment. I first tested with the affected version (6.1.1.GA) and found that the app immediately crashed upon launch. I tried it a few times and it crashed repeatedly. Then I tried with the fixed version. I updated the test case to have different colors for each window so it would be evident when the windows scroll. The windows did scroll as expected, and at no time did I experience any crashes.

@mukherjee2 mukherjee2 merged commit 1c8adae into tidev:master Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants