Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24930] Fix build process erroring when NDK path not set #9194

Merged
merged 2 commits into from Jul 5, 2017
Merged

[TIMOB-24930] Fix build process erroring when NDK path not set #9194

merged 2 commits into from Jul 5, 2017

Conversation

ewanharris
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-24930

  • Only check for existence of this.androidInfo.ndk

Verification

  1. Remove the NDK path from your ti config, [appc] ti config --remove android.ndkPath or hand edit the file
  2. Build an Android module
    • Should error with [ERROR] Unable to find a suitable installed Android NDK.

@ewanharris ewanharris requested a review from cb1kenobi July 5, 2017 10:25
cb1kenobi
cb1kenobi approved these changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. APPROVED

@cb1kenobi cb1kenobi merged commit f874db9 into tidev:master Jul 5, 2017
@ewanharris ewanharris deleted the TIMOB-24930 branch August 31, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewanharris @cb1kenobi