[TIMOB-24943] CLI: Install command patch for Windows platform. #9198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypbnv
changed the title
cb1kenobi
requested changes
Jul 6, 2017
build/scons-install.js
Outdated
| @@ -38,7 +38,7 @@ function install(versionTag, next) { | |||
|
|
|||
| // TODO Combine with unzip method in packager.js? | |||
| // TODO Support unzipping on windows | |||
| exec('/usr/bin/unzip -q -o -d "' + dest + '" "' + zipfile + '"', function (err, stdout, stderr) { | |||
| exec('unzip -q -o -d "' + dest + '" "' + zipfile + '"', function (err, stdout, stderr) { | |||
There was a problem hiding this comment.
unzip is not a valid command on Windows. You should use the unzip function in node-appc. To do this, first require node-appc:
var appc = require('node-appc');Then unzip!
appc.zip.unzip(zipfile, dest, next);
|
@cb1kenobi Updated. |
cb1kenobi
approved these changes
Jul 6, 2017
jquick-axway
added a commit
to jquick-axway/titanium_mobile
that referenced
this pull request
Jul 24, 2017
- Bug was introduced on Mac and Windows as of PR tidev#9198. - Note that this works-around a bug in CLI appc.zip.unzip() function, which is to be fixed later.
|
@ypbnv, you should check if there is a Windows bug with the following command as well... The above does a clean, build, package, and install all at once. I've noticed the JavaScript for this command contains a copy of the old unzip code that you might want to change over to use |
|
@jquick-axway Checked it - 'cleanbuild' on Windows does have the same problem. Since this PR introduces an issue - should I apply the changes from it for 'cleanbuild'? |
|
@jquick-axway Here is a combined PR: #9259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24943
Description:
Installing a built from sources SDK fails on Windows.
Here I am not sure if stripping the 'unizp' command would work fine on OS X.