Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6_1_X][TIMOB-24710] Android: Only dispose valid runtime #9200

Merged
merged 2 commits into from Jul 19, 2017
Merged

[6_1_X][TIMOB-24710] Android: Only dispose valid runtime #9200

merged 2 commits into from Jul 19, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 6.1.2 milestone Jul 6, 2017
jquick-axway
jquick-axway approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@mukherjee2 mukherjee2 self-requested a review July 19, 2017 17:50
mukherjee2
mukherjee2 approved these changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment •
edited by hansemannn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed FR with this environment:
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.X PR-9200
Appcelerator Studio, build: 4.9.0.201705302345
Android Version: 7.1.2

I was not able to reproduce the original bug, however I tested the PR by creating an app, and running adb logcat to check for error messages. I tried several things such as backing out of the app, and putting it in the background while watching the logcat window I had open. None of the originally reported errors were observed, so I am merging the ticket. I'll keep the status as "Resolved" (ie not "Closed") until confirmation that reporter of the bug does not get any more errors.

@hansemannn hansemannn merged commit 86ae65a into tidev:6_1_X Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
6.1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @mukherjee2 @jquick-axway @hansemannn