[6_1_X][TIMOB-24926] Android: Prevent fireEvent on null proxy #9204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukherjee2
approved these changes
Jul 10, 2017
There was a problem hiding this comment.
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.1.GA
Appcelerator Studio, build: 4.9.0.201705302345
Xcode 8.3.2
Android Device 7.1.2 (Pixel)
FR Passed with above environment. I first tested with the affected version (6.1.1.GA) and found that the app immediately crashed upon launch. I tried it a few times and it crashed repeatedly. Then I tried with the fixed version. I updated the test case to have different colors for each window so it would be evident when the windows scroll. The windows did scroll as expected, and at no time did I experience any crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket