(6_1_X) [TIMOB-24932] Android Hybrid modules: cannot instantiate a proxy in a js file that is packaged in the same module #9206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a js file that is packaged in the same module
ewanharris
approved these changes
Jul 11, 2017
There was a problem hiding this comment.
FR Pass!
Node.js 6.11.0
OSX 10.12.5
Appc CLI 6.2.2
Appc NPM 4.2.9
Appcelerator Studio 4.9.0.201705302345
Android Device 7.1.1 OnePlus 3
FR Passed
Demo in ticket works as expected now and calling native functions from a packaged js file works. Exercised functionality such as requiring other modules and it also worked as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24932
Description:
Calling
require('module.id')from inside a JS file in that module's assets folder would fail (specifically this is when you're creating "hybrid" native modules for Android that combine Java proxies and JS code). See the ticket for steps to reproduce.The fix here was to avoid clobbering the native half of the hybrid module in our cache object. Before we'd insert the CommonJS half of the hybrid API into our require cache over top the native module. We need to keep just the native half and recreate the combination of both when required from different files since apparently it's context specific (and so the combined wrapper is cached per-module).