[TIMOB-24808]: iOS 11 Add support for Password AutoFill #9210

vijaysingh-axway · 2017-07-10T04:10:48Z

https://jira.appcelerator.org/browse/TIMOB-24808

hansemannn

Needs some more adjustments in order to be approved, but looking forward to get those solved easily. Thx!

hansemannn · 2017-07-10T05:33:49Z

apidoc/Titanium/UI/TextArea.yml

+  - name: textContentType
+    summary: Provide the keyboard with extra information about the semantic intent of the text 
+        document.
+    type: String


Break summary into two lines.

hansemannn · 2017-07-10T05:34:06Z

apidoc/Titanium/UI/TextArea.yml

+        document.
+    type: String
+    constants: Titanium.UI.iOS.CONTENT_TYPE_*
+    default: <NULL>


Do not specify the default value if none is set.

hansemannn · 2017-07-10T05:34:22Z

apidoc/Titanium/UI/TextArea.yml

+    summary: Provide the keyboard with extra information about the semantic intent of the text 
+        document.
+    type: String
+    constants: Titanium.UI.iOS.CONTENT_TYPE_*


Should be [Titanium.UI.iOS.CONTENT_TYPE_*]

I think if the method accepts single constants it should be mentioned like Titanium.UI.iOS.CONTENT_TYPE_* rather [Titanium.UI.iOS.CONTENT_TYPE_*] . e.g. see "keyboardType" inside TextArea.yml.

hansemannn · 2017-07-10T05:34:53Z

apidoc/Titanium/UI/TextField.yml

+    default: <NULL>
+    platforms: [iphone, ipad]
+    since: "6.2.0"
+    osver: {ios: {min: "10.0"}}


Same things as above (break into two lines, brackets in the constants value, no default value.

hansemannn · 2017-07-10T05:38:02Z

apidoc/Titanium/UI/iOS/iOS.yml

@@ -1699,6 +1699,231 @@ properties:
    osver: {ios: {min: "9.1"}}
    since: "5.1.0"

+  - name: CONTENT_TYPE_NAME
+    summary: Tell keyboard that content type is, name.


That sounds weird. Please use the Apple phrasing for all constants.

Do you mean it should be like TEXT_CONTENT_TYPE_NAME ? I just tried to make the constant name shorter.

No, the summary should be proper english.

hansemannn · 2017-07-10T05:39:23Z

apidoc/Titanium/UI/iOS/iOS.yml

+  - name: CONTENT_TYPE_PASSWORD
+    summary: Tell keyboard that content type is, password.
+    description: |
+        Use with <Titanium.UI.TextField.textContentType> or <Titanium.UI.TextArea.textContentType>.    


This should also have a paragraph about the default behavior of fields having both email-address keyboard appearance and password-mask enabled, because in that case the password-autofill will be enabled automatically.

Sorry, I didn't get. Are you talking about to write a note about how to enable password autofill ?

If people use the keyboard-type "email" and the text-fied property "passwordMask", it will enable auto-fill automatically, even when you did not build for iOS 11. That should be noted as an own paragraph there.

We are not mentioning anything related password autofill in document. So I don't think we should write above detail here. Better is we should write a wiki for giving detail about autofill password.

hansemannn · 2017-07-10T05:45:05Z

iphone/Classes/TiUITextWidget.m

+-(void)setTextContentType_:(id)value
+{
+    ENSURE_TYPE_OR_NIL(value, NSString);
+    if (@available(iOS 10.0, *)) {


This whole method should be rewritten, since it has way too much manual logic and some missing guard inside it. Let try this something like this:

- (void)setTextContentType_:(id)value { ENSURE_TYPE_OR_NIL(value, NSString); if (![TiUtils isIOS10OrGreater]) { NSLog(@"Setting a text-content-type is only available on iOS 10 and later"); return; } [[self textWidgetView] setTextContentType:[TiUtils stringValue:value]]; }

This has some advantages:

Constants are mapped to it's values automatically

There is no need for the Xcode 9-only @available syntax

There is no need for the (currently missing) #if IS_XCODE_9 macros

iOS 11 constants do not need to be checked manually.

Less error-prone due to no manual validation

if (![TiUtils isiOS10OrGreater]) { NSLog(@"Setting a text-content-type is only available on iOS 10 and later"); return; } , I agree.

With [[self textWidgetView] setTextContentType:[TiUtils stringValue:value]], I have already tried but it didn't worked. When I saw the class type of [TiUtils stringValue:value], it gives value "NSTaggedPointerString " and for content type "__NSCFConstantString". This api accept only Constant string.
So we have to make the method large with manual logic.

You can just cast the string (see similar to here), mapping everything manually cannot be the best solution.

We can not convert NSstring to __NSCFConstantString. If we do-
NSString *str = @"test string", it get automatically converted. It is done at compile time. Either we can simply write -
textContentType = @"username"
or we write
textContentType = UITextContentTypeUsername
In both cases we have to use if else condition for differentiation. First option is not good as we have to get the string value of each UITextContentType and write there.

hansemannn · 2017-07-10T05:45:51Z

iphone/Classes/TiUIiOSProxy.m

@@ -840,5 +840,36 @@ -(id)createFeedbackGenerator:(id)args
 #endif
 #endif

+#if defined(USE_TI_UITEXTWIDGET) || defined(USE_TI_UITEXTAREA) || defined(USE_TI_UITEXTFIELD)


USE_TI_UITEXTWIDGET is always defined when USE_TI_UITEXTAREA or USE_TI_UITEXTFIELD is defined, so I cannot think of a case where it is required to be checked manually.

hansemannn · 2017-07-10T05:46:18Z

iphone/Classes/TiUIiOSProxy.m

+MAKE_SYSTEM_STR(CONTENT_TYPE_MIDDLE_NAME, UITextContentTypeMiddleName);
+MAKE_SYSTEM_STR(CONTENT_TYPE_FAMILY_NAME, UITextContentTypeFamilyName);
+MAKE_SYSTEM_STR(CONTENT_TYPE_NAME_SUFFIX, UITextContentTypeNameSuffix);
+MAKE_SYSTEM_STR(CONTENT_TYPE_NICK_NAME, UITextContentTypeNickname);


Should be CONTENT_TYPE_NICKNAME , please also update inside the docs.

hansemannn · 2017-07-10T05:47:22Z

iphone/Classes/TiUIiOSProxy.m

+MAKE_SYSTEM_STR(CONTENT_TYPE_CREDIT_CARD_NUMBER, UITextContentTypeCreditCardNumber);
+
+#if IS_XCODE_9
+MAKE_SYSTEM_STR(CONTENT_TYPE_USER_NAME, UITextContentTypeUsername);


Should be CONTENT_TYPE_USERNAME, please also update inside the docs and JIRA example-code.

vijaysingh-axway · 2017-09-14T07:46:04Z

Closing in favor of #9368

[TIMOB-24808]: iOS 11 Add support for Password AutoFill

cd3db76

hansemannn requested changes Jul 10, 2017

View reviewed changes

hansemannn added this to the 6.2.0 milestone Jul 10, 2017

hansemannn added feature ios iOS11 labels Jul 10, 2017

hansemannn assigned vijaysingh-axway Jul 10, 2017

vijaysingh-axway added 2 commits July 10, 2017 16:55

[TIMOB-24808]: Constant name fixed.

93a3c53

[TIMOB-24808]:doc updated and ios 10 check applied

687048a

hansemannn removed this from the 6.2.0 milestone Jul 20, 2017

vijaysingh-axway closed this Sep 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-24808]: iOS 11 Add support for Password AutoFill #9210

[TIMOB-24808]: iOS 11 Add support for Password AutoFill #9210

vijaysingh-axway commented Jul 10, 2017

hansemannn left a comment

hansemannn Jul 10, 2017

hansemannn Jul 10, 2017

hansemannn Jul 10, 2017

vijaysingh-axway Jul 10, 2017

hansemannn Jul 10, 2017

hansemannn Jul 10, 2017

vijaysingh-axway Jul 10, 2017 •

edited

hansemannn Jul 10, 2017

vijaysingh-axway Jul 11, 2017

hansemannn Jul 10, 2017

vijaysingh-axway Jul 10, 2017

hansemannn Jul 10, 2017

vijaysingh-axway Jul 11, 2017

hansemannn Jul 10, 2017 •

edited

vijaysingh-axway Jul 10, 2017

hansemannn Jul 10, 2017 •

edited

vijaysingh-axway Jul 11, 2017

hansemannn Jul 10, 2017

vijaysingh-axway Jul 11, 2017

hansemannn Jul 10, 2017

vijaysingh-axway Jul 11, 2017

hansemannn Jul 10, 2017

vijaysingh-axway commented Sep 14, 2017

[TIMOB-24808]: iOS 11 Add support for Password AutoFill #9210

[TIMOB-24808]: iOS 11 Add support for Password AutoFill #9210

Conversation

vijaysingh-axway commented Jul 10, 2017

hansemannn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vijaysingh-axway Jul 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansemannn Jul 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansemannn Jul 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vijaysingh-axway commented Sep 14, 2017

vijaysingh-axway Jul 10, 2017 •

edited

hansemannn Jul 10, 2017 •

edited

hansemannn Jul 10, 2017 •

edited