Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24949] Android: Remove unnecessary % escapes from logs #9213

Merged
merged 3 commits into from Jul 12, 2017

Conversation

garymathews
Copy link
Contributor

  • Remove unnecessary escape characters %% from logs
TEST CASE
console.log('%');
%

JIRA Ticket

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@jquick-axway
Copy link
Contributor

jquick-axway commented Jul 11, 2017

QE should also test the following:

console.log("%d %f %x %s %%");

^ This is to make sure the log string is not being passed to a string format function on the C/C++ side.

@garymathews
Copy link
Contributor Author

@jquick-axway We don't (but should) support that TIMOB-24950

@jquick-axway
Copy link
Contributor

@garymathews, I was referring to how we log messages internally in Titanium. In this case, I'm expecting the '%' characters to be taken literally. It doesn't hurt to double check.

@lokeshchdhry
Copy link
Contributor

FR Passed.

We now see only one %.
Checked with console.log('%'); & console.log("%d %f %x %s %%");

Studio Ver: 4.9.0.201705302345
SDK Ver: 6.2.0.v20170712153750 from Jenkins
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.2
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 938ce56 into tidev:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants