[TIMOB-17493] Android: Default Translucent theme overwrites custom themes. #9216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garymathews
reviewed
Jul 11, 2017
| @@ -3338,18 +3338,21 @@ AndroidBuilder.prototype.generateTheme = function generateTheme(next) { | |||
| this.logger.info(__('Generating %s', themeFile.cyan)); | |||
|
|
|||
| var flags = 'Theme.AppCompat'; | |||
| var defaultProvidedTheme = '@style/' + flags; | |||
There was a problem hiding this comment.
You shouldn't need to change anything in this file
garymathews
reviewed
Jul 11, 2017
| @@ -33,7 +33,13 @@ | |||
| <!-- AppCompat Compatibility --> | |||
| <item name="actionBarStyle">@style/Base.Widget.AppCompat.ActionBar.Solid</item> | |||
| </style> | |||
|
|
|||
|
|
|||
| <style name="Theme.AppCompat.Translucent.Default" parent="<%- defaultProvidedTheme %>"> | |||
There was a problem hiding this comment.
Why not remove
<item name="android:actionBarStyle">@style/Base.Widget.AppCompat.ActionBar.Solid</item>
<item name="actionBarStyle">@style/Base.Widget.AppCompat.ActionBar.Solid</item>from Theme.AppCompat.Translucent ?
NOTE: Update the docs
|
Closed due to being out of sync with latest build and themes changes. Will reopen once I get it back on track or I will create a new one for the issue (if it is still relevant). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-17493
Description:
The default Translucent theme used for activities with opacity property, modal property and incorrect background color format, overwrites any custom theme's values.
Test case:
Custom theme and case provided in the ticket.
Another test case:
Add the following to tiapp.xml:
app.js
As Theme.Titanium has ActionBar disabled I expected to get a translucent window without ActionBar. I got a window with an ActionBar.
Note:
It seems that one of the templates for generating Android manifest file is not used at all. I successfully built and SDK instance and a application without it. Removed it to avoid confusion.