Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24351]:iOS Support "editActions" in listview search-results #9227

Merged
merged 12 commits into from Aug 18, 2017

Conversation

vijaysingh-axway
Copy link
Contributor

@hansemannn
Copy link
Collaborator

This PR depends on the one you published earlier right? We should merge that one first and then rebase this one.

@vijaysingh-axway
Copy link
Contributor Author

Correct.

Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New FR will happen after dependency PR is merged

@hansemannn
Copy link
Collaborator

@ewieberappc Can you FT #9066 before? As soon as that one is merged, Vijay can rebase this PR and we can test the related changes for the edit-actions. Thx!

Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until #9066 is merged.

@ewieberappc
Copy link
Contributor

@hansemannn @vijaysingh-axway, #9066 is merged. We can unblock and rebase now.

@hansemannn
Copy link
Collaborator

hansemannn commented Aug 11, 2017

@ewieberappc Done! Will do the CR on monday, you can check the FT right now already if you want 🙂.

@ewieberappc ewieberappc self-requested a review August 14, 2017 20:49
@hansemannn hansemannn modified the milestones: 7.0.0, 6.2.0 Aug 15, 2017
@hansemannn
Copy link
Collaborator

@vijaysingh-axway Please revert @fe63d07 and resolve locally. It seems my tries to resolve the merge-conflicts online did not succeed.

Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed.
Able to perform edit/delete actions on search results for ListViews and TableViews using searchbars

@ewieberappc ewieberappc merged commit b356246 into tidev:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants