[TIMOB-24830] (6_1_X) iOS: require cache improvements #9232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to resolved path; consult cache BEFORE tryign to load files
…ath cache key generation, and storing resolved paths for the key; Add path/module cache logging so you can see what's going on.
…rrent dir segement as empty (basically share path cache keys from any dir if the request is absolute)
|
back port of #9158. We also will need a backport/cherry-pick to 6_2_X now, since the original PR is unmarked and targeted at master (which is now 7_0_X target). |
mukherjee2
approved these changes
Jul 26, 2017
There was a problem hiding this comment.
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.2
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.2 (locally built)
Appcelerator Studio, build: 4.9.0.201705302345
Xcode 8.3.2
iOS 10
Passed FR with the above environment. I ran the demo app with debug flag. There were no compile-time or runtime errors. The debug messages that were shown in the description were not seen (or similar).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24830