Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25007] Android: repeatMode for VideoPlayer #9241

Merged
merged 4 commits into from Aug 11, 2017
Merged

[TIMOB-25007] Android: repeatMode for VideoPlayer #9241

merged 4 commits into from Aug 11, 2017

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 21, 2017 •
edited by hansemannn

@m1ga m1ga changed the title Android: repeatMode for VideoPlayer [AC-5103] Android: repeatMode for VideoPlayer Jul 21, 2017
@hansemannn hansemannn changed the title [AC-5103] Android: repeatMode for VideoPlayer [TIMOB-25007] Android: repeatMode for VideoPlayer Jul 21, 2017
@hansemannn hansemannn added this to the 7.0.0 milestone Jul 21, 2017
garymathews
garymathews approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

👍

@ssjsamir ssjsamir self-requested a review August 7, 2017 22:31
@lokeshchdhry
Copy link
Contributor

FR Passed.

repeatMode VIDEO_REPEAT_MODE_ONE & VIDEO_REPEAT_MODE_NONE works as expected.

Studio Ver: 4.9.1.201707200100
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.3
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.13
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ motorola XT1033 --- Android 4.4.4
⇨ google Pixel --- Android 7.1.1

@lokeshchdhry lokeshchdhry merged commit 44a8c33 into tidev:master Aug 11, 2017
@m1ga m1ga deleted the videoplayer branch September 9, 2017 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

@ssjsamir ssjsamir Awaiting requested review from ssjsamir

Assignees
No one assigned
Labels
android community 🔥 improvement in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@m1ga @lokeshchdhry @garymathews @sgtcoolguy @hansemannn @ssjsamir