Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25016] Bumped ioslib to 1.5.0 which bumps node-ios-device to 1… #9243

Merged
merged 2 commits into from Jul 26, 2017
Merged

[TIMOB-25016] Bumped ioslib to 1.5.0 which bumps node-ios-device to 1… #9243

merged 2 commits into from Jul 26, 2017

Conversation

cb1kenobi
Copy link
Contributor

[TIMOB-25016] Bumped ioslib to 1.5.0 which bumps node-ios-device to 1.4.0 which allows installing, but not building, on Windows and Linux.

JIRA: https://jira.appcelerator.org/browse/TIMOB-25016

….4.0 which allows installing, but not building, on Windows and Linux.
@cb1kenobi cb1kenobi self-assigned this Jul 24, 2017
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FT: PASS

Although an attempt to compile node-ios-device still occurs, the package is skipped on failure allowing npm install to continue. Removed my npm-cache, node-ios-device compilation is skipped.

$ npm install
npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
npm WARN deprecated wrench@1.5.9: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
npm WARN deprecated wrench@1.5.8: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
npm WARN prefer global jshint@2.9.5 should be installed with -g
npm WARN prefer global jsonlint@1.6.2 should be installed with -g
npm WARN prefer global coffee-script@1.10.0 should be installed with -g

> node-ios-device@1.4.0 install C:\Users\gmathews\github\titanium_mobile\node_modules\node-ios-device
> node ./bin/run.js node-pre-gyp install --fallback-to-build

Skipping for win32

npm notice created a lockfile as package-lock.json. You should commit this file.
added 503 packages in 26.082s

@garymathews
Copy link
Contributor

@cb1kenobi package-lock.json needs updating too?

@cb1kenobi
Copy link
Contributor Author

@garymathews Fixed the package-lock.json.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@garymathews garymathews merged commit be7d93c into tidev:master Jul 26, 2017
@cb1kenobi cb1kenobi deleted the timob-25016 branch July 26, 2017 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants