Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25021] Android: Fix deletion of weak global reference #9246

Merged
merged 2 commits into from Aug 1, 2017

Conversation

garymathews
Copy link
Contributor

  • Fix deletion of weak global references
TEST CASE
var win = Ti.UI.createWindow({backgroundColor: 'gray', exitOnClose: true});
win.open();
  1. Launch application
  2. Press back to exit the application
  3. Quickly re-launch the application by pressing the application icon (you may want to add a shortcut to your homescreen)
  4. This may take a few attempts

JIRA Ticket

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR looks good 👍

@ssjsamir
Copy link
Contributor

ssjsamir commented Aug 1, 2017

FR Passed: was able to launch the application and close it and quickly launch it again multiple times without any errors.

Test steps:

  • Created a build of the SDK using this PR
  • Created a new Titanium project
  • Added the following in to the app.js
var win = Ti.UI.createWindow({backgroundColor: 'gray', exitOnClose: true});
win.open();
  • Launched the application
  • Pressed back to exit the application
  • Quickly re-launched the application by pressing the application icon
  • Repeated multiple times
  • error relating to global issue was no longer shown

Test Environment
Appcelerator Command-Line Interface, version 6.2.3-21
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Appcelerator Studio: 4.9.0.201705302345

@ssjsamir ssjsamir merged commit de7c7ee into tidev:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants