Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_1_X][TIMOB-24911] Android: Filtering R. files when building Android modules does not work on Windows #9250

Merged
merged 5 commits into from Jul 27, 2017

Conversation

garymathews
Copy link
Contributor

@ssjsamir ssjsamir self-requested a review July 27, 2017 17:26
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed was able to filter out "R. files" when building module to Android on the Windows platform.

Test steps

  • Used this PR to build an SDK for 6_1_X
  • Downloaded the module form https://github.com/viezel/NappDrawer
  • Built the module using appc run -p android --build-only
  • I then built the module using 6.1.1.GA and saw that the file size was halved in 6_1_X
  • I then created a Titanium Project and used 6_1_X and added the module built from 6_1_X
  • Saw that application run without any issues
  • I then ran the 6_1_X module with 6.1.1.GA and application ran without any issues.

Test Environment
APPC Studio: 4.9.0.201705180402
APPC CLI: 6.2.2
Nexus 6P (7.1.1)
Operating System:
Name = Microsoft Windows 10 Pro
Version = 10.0.14393
Architecture = 32bit
CPUs = 4
Node.js:
Node.js Version = 6.10.1

@ssjsamir ssjsamir merged commit c4cd761 into tidev:6_1_X Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants