[TIMOB-4272] & [TIMOB-4363] -- TableView doc fixes #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 12, 2011 10:51
TIMOB-4272 & TIMOB-4363 Changes: - Added missing argument to updateRow - Fixed summaries for insertRowBefore and insertRowAfter - Took some liberties by inventing a new pseudotype for animation properties. - Added a pseudotype for indexEntries (for the iOS-only index property) as well. - Removed unsupported events. - Added the missing click event. - Marked index, style, selectionStyle - Marked selectRow, deselectRow as unsupported on Android - Edited for style & content & expanded some descriptions. Whew!
Updated to address review comments.
Updated to address review comments. Added some missing types to the event properties.
|
Code review and functional test (validate and a docgen spot check) accepted. |
added 2 commits
December 12, 2011 13:49
… into timob-4272-1_8_X
Fixed typo.
| type: Number | ||
| - name: scrollable | ||
| summary: true (default) if tableview can be scrolled | ||
| summary: If true (default) if tableview can be scrolled |
There was a problem hiding this comment.
If true if tableview can be scrolled?
|
Aha. Didn't see the fix. Now it looks good. ACCEPTED. |
|
D'oh. Fixed typo. Um, for some reason github shows my fix for this coming in 17 minutes before Blain pointed it out. Rest assured this is due to temporary flux in the time-space matrix. |
|
Code re-review and re-test accepted |
billdawson
added a commit
that referenced
this pull request
Dec 13, 2011
[TIMOB-4272] & [TIMOB-4363] -- TableView doc fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.