[TIMOB-25028] Fix issue where node-ios-device is not hoisted #9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
requested changes
Jul 26, 2017
build/packager.js
Outdated
| cb(); | ||
| }); | ||
| if (this.targetOS === 'osx') { | ||
| console.log(path.join(this.zipSDKDir, 'node_modules', 'node-ios-device')); |
There was a problem hiding this comment.
Is the console.log() debug? It should probably be removed.
build/packager.js
Outdated
| } | ||
| cb(); | ||
| }); | ||
| } else if (fs.existsSync(normalPath)) { |
There was a problem hiding this comment.
You have a lot of duplicate code. It can be simplified:
let dir = path.join(this.zipSDKDir, 'node_modules', 'node-ios-device');
if (!fs.existsSync(dir)) {
dir = path.join(this.zipSDKDir, 'node_modules', 'ioslib', 'node_modules', 'node-ios-device');
}
if (!fs.existsSync(dir)) {
return cb(new Error('Unable to find node-ios-device module'));
}
exec('node bin/download-all.js', { cwd: dir, stdio: 'inherit' }, cb);There was a problem hiding this comment.
Yeah my bad I was thinking that it could be better as I wrote it, updated. I kept the exec usage similar to the others throughout the file,
cb1kenobi
reviewed
Jul 26, 2017
build/packager.js
Outdated
| return cb(new Error('Unable to find node-ios-device module')); | ||
| } | ||
|
|
||
| exec('node bin/download-all.js', {cwd: dir}, function (err, stdout, stderr) { |
There was a problem hiding this comment.
I would just inherit stdio, then you don't need to manually print the stdout/stderr. You can just pass in cb like this:
exec('node bin/download-all.js', { cwd: dir, stdio: 'inherit' }, cb);Also note that we put spaces inside braces/brackets around the props/elements.
cb1kenobi
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25028
node-ios-device can be in
node_modulesornode_modules/ioslib/node_moduleswe should consider that when executing the script.Verification