Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25028][6_2_X] Fix issue where node-ios-device is not hoisted #9261

Merged
merged 2 commits into from Jul 27, 2017

Conversation

ewanharris
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-25028

Backport of #9260

node-ios-device can be in node_modules or node_modules/ioslib/node_modules we should consider that when executing the script.

Verification

  1. Run node build/scon.js package ios
    • It should not error out
  2. Let Jenkins run
    • It should be happy

@ewanharris ewanharris changed the title [TIMOB-25028] Fix issue where node-ios-device is not hoisted [TIMOB-25028][6_2_X] Fix issue where node-ios-device is not hoisted Jul 26, 2017
@ewanharris
Copy link
Collaborator Author

@cb1kenobi Sorry forgot to assign you to the backport, could you merge when you have time please and thank you! :)

@sgtcoolguy
Copy link
Contributor

LGTM 👍

@sgtcoolguy sgtcoolguy merged commit cb87311 into tidev:6_2_X Jul 27, 2017
@ewanharris ewanharris deleted the TIMOB-25028_6_2_X branch August 31, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants