Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25030] Android: Include Windows gperf binary #9263

Closed
wants to merge 2 commits into from

Conversation

garymathews
Copy link
Contributor

  • Include gperf binary for native Android module development on Windows
TEST CASE
appc new -p android -t timodule -n module --id com.module
cd module\android
appc run -p android --build-only
  • Should compile without errors

JIRA Ticket

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy
Copy link
Contributor

Doesn't this have a GPL license? Can we include this legally? Also, it looks like we're including not just the binary, but all the source too.

@cb1kenobi
Copy link
Contributor

@sgtcoolguy We can add it to the repo, but we cannot distribute it.

@cb1kenobi
Copy link
Contributor

So, question, does scons add it to the distribution zip file?

@ypbnv
Copy link
Contributor

ypbnv commented Jul 27, 2017

Yes, it does.

@garymathews
Copy link
Contributor Author

garymathews commented Jul 27, 2017

@sgtcoolguy GPLv2 license, requires source to be available along with the license. That seems to be the only limitation. Which is why the source is included, this means we can distribute it with our SDK.

GNU GPLv2

Maybe I should zip the source?

@cb1kenobi
Copy link
Contributor

@garymathews I think that we have/had contracts with customers that forbid us from distributing GPL dependencies with Titanium. We have a ticket to remove gperf because of this.

@garymathews
Copy link
Contributor Author

It would be nice to remove it as a dependency. I found TIMOB-10724 but that's because the user couldn't build an Android module on Windows due to not having gperf, which this will fix.

@cb1kenobi
Copy link
Contributor

@ingo Is it OK to:

A) commit GPL software to the titanium_mobile repo

and

B) bundle GPL software with the Titanium SDK distribution zip file?

@ingo
Copy link
Contributor

ingo commented Jul 27, 2017

I don't believe we can commit it. Can't we just remove the dependency? It seems like it could be replaced by a different piece of software.

@garymathews
Copy link
Contributor Author

Closing in favour of #9265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants