New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25030] Android: Include Windows gperf binary #9263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
Doesn't this have a GPL license? Can we include this legally? Also, it looks like we're including not just the binary, but all the source too. |
@sgtcoolguy We can add it to the repo, but we cannot distribute it. |
So, question, does scons add it to the distribution zip file? |
Yes, it does. |
@sgtcoolguy GPLv2 license, requires source to be available along with the license. That seems to be the only limitation. Which is why the source is included, this means we can distribute it with our SDK. Maybe I should zip the source? |
@garymathews I think that we have/had contracts with customers that forbid us from distributing GPL dependencies with Titanium. We have a ticket to remove gperf because of this. |
It would be nice to remove it as a dependency. I found TIMOB-10724 but that's because the user couldn't build an Android module on Windows due to not having gperf, which this will fix. |
@ingo Is it OK to: A) commit GPL software to the titanium_mobile repo and B) bundle GPL software with the Titanium SDK distribution zip file? |
I don't believe we can commit it. Can't we just remove the dependency? It seems like it could be replaced by a different piece of software. |
Closing in favour of #9265 |
gperf
binary for native Android module development on WindowsTEST CASE
JIRA Ticket