Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-20404]: iOS ProgressBar gets clipped in parent with height Ti.UI.SIZE #9273

Merged
merged 11 commits into from Nov 7, 2017
Merged

[TIMOB-20404]: iOS ProgressBar gets clipped in parent with height Ti.UI.SIZE #9273

merged 11 commits into from Nov 7, 2017

Conversation

vijaysingh-axway
Copy link
Contributor

@hansemannn hansemannn added this to the 7.0.0 milestone Aug 7, 2017
hansemannn
hansemannn requested changes Aug 7, 2017
View reviewed changes
iphone/Classes/TiUIProgressBar.m Outdated
if (messageLabel == nil) {
return fontSize.height + progressSize.height;
}
return fontSize.height + progressSize.height + 5;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is incorrect. I also feel like this is not the proper way to fix it (by manually setting a constant value of 5 just to unclip it). I need to spend more time reviewing the progress-bar layout-code this week.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansemannn, If you see function -(void)layoutSubviews in same file, there is code snippet -
float fittingHeight = barSize.height + messageSize.height + 5;

which sets the gap of 5 pixel between message and progress bar. So while calculating height it should also give +5 pixel, if message is there.

hansemannn
hansemannn approved these changes Aug 10, 2017
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ssjsamir ssjsamir self-requested a review August 10, 2017 22:19
@build
Copy link
Contributor

build commented Oct 10, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Generated by 🚫 dangerJS

@build build added the ios label Nov 2, 2017
@sgtcoolguy sgtcoolguy merged commit 39117c4 into tidev:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

@ssjsamir ssjsamir Awaiting requested review from ssjsamir

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @hansemannn @sgtcoolguy @ssjsamir